refactor: lift hideBalance state to parent composable#755
Open
refactor: lift hideBalance state to parent composable#755
Conversation
This comment has been minimized.
This comment has been minimized.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #752 (comment)
This PR lifts the
hideBalancestate fromActivityDetailContentto its parentActivityDetailScreen, following the parent-child composable pattern.Description
The
ActivityDetailContentcomposable was accessingsettingsViewModeldirectly instead of receiving state as a parameter from its parent. This violated the CLAUDE.md rule: "ALWAYS split screen composables into parent accepting viewmodel + inner private child accepting state and callbacks".Changes:
settingsViewModelandhideBalancestate access to parentActivityDetailScreenhideBalance: Booleanparameter toActivityDetailContentPreview
N/A - No visual changes, refactoring only
QA Notes
1. Hide balance on activity detail
• • • • • • • • •• • • • •• • • • •(if applicable)2. Show balance on activity detail